Missing check in RemoveSentReliableCommand.
juliolitwin opened this issue · comments
Julio Litwin commented
The function of RemoveSentReliableCommand is missing a check equal to the original. Is it on purpose?
Line 430 in c15bd79
if (outgoingCommand.reliableSequenceNumber == reliableSequenceNumber &&
outgoingCommand.command.Header.ChannelID == channelID)
break;
ENet:
https://github.com/lsalzman/enet/blob/e3ada4ed750b976833e3d54a9c1179445289bbf6/protocol.c#L210
Cheers.
Havij khor commented
Thanks for the report, it's a mistake, can you make a PR?
Havij khor commented
I checked it again, and I realized that it is refactored that's why it looks different from the original code.