moien007 / NENet

An ENet implementation in .NET

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing check in RemoveSentReliableCommand.

juliolitwin opened this issue · comments

The function of RemoveSentReliableCommand is missing a check equal to the original. Is it on purpose?

outgoingCommand = currentOutgoingCommand;

                    if (outgoingCommand.reliableSequenceNumber == reliableSequenceNumber &&
                        outgoingCommand.command.Header.ChannelID == channelID)
                        break;

ENet:
https://github.com/lsalzman/enet/blob/e3ada4ed750b976833e3d54a9c1179445289bbf6/protocol.c#L210

Cheers.

Thanks for the report, it's a mistake, can you make a PR?

I checked it again, and I realized that it is refactored that's why it looks different from the original code.