Mismatch betweet git tag and bower.json version numbers

Question

Mismatch betweet git tag and bower.json version numbers

jdhoek opened this issue 10 years ago · comments

Git tag v2.0.5 points to a bower.json that says "version": "2.0.3",. This causes bower to issue a warning about this mismatch when installing modular-scale with bower install --save modular-scale.

Could you update bower.json's version for future releases?

Jeroen Hoek · Answer 1 · Wed May 28 2014 19:43:05 GMT+0800 (China Standard Time)

Also, git tag 2.0.4 should be v2.0.4.

Scott Kellum · Answer 2 · Sat May 31 2014 08:44:15 GMT+0800 (China Standard Time)

thanks, updated bower.json to the latest version

Jeroen Hoek · Answer 3 · Sun Jun 01 2014 16:43:52 GMT+0800 (China Standard Time)

My apologies, it seems my comment about the git tags wasn't entirely clear and caused you some confusion. With v2.0.4 I was referring to the git tags in this repository, as they are used by Bower to resolve versions. After that Bower downloads the tagged commit, and reads it bower.json.

In bower.json the version number should read 2.0.5 (customarily without the v, although it works with it as well). So "version": "2.0.5" is correct in bower.json.

In the git repository, the git tags should always be prefixed with a v, so v2.0.5. I would recommend removing git tags 2.0.4 and 2.0.5 in favour of v2.0.4 and v2.0.5.

Jeroen Hoek · Answer 4 · Sun Jun 01 2014 16:45:46 GMT+0800 (China Standard Time)

By the way, the modular-scale SASS works great. Nice to have this available from Bower.

Scott Kellum · Answer 5 · Sun Jun 01 2014 23:22:15 GMT+0800 (China Standard Time)

Thanks for bearing with me @jdhoek. It’s probably pretty obvious I don’t actually use Bower.

I removed 2.0.5 and 2.0.4. From your latest comment I assume the v is implied in the bower.json. In future releases I will remove it.

Jeroen Hoek · Answer 6 · Mon Jun 02 2014 16:01:50 GMT+0800 (China Standard Time)

My pleasure.

In Bower the version field is read with NPM's semver package, which accepts version numbers with v as well as without, but most packages I've come across (like jquery etc.) do without the v. It's probably all right to use v2.6.0 in bower.json as well, just unconventional.