modularscale / modularscale-sass

Modular scale calculator built into your Sass

Home Page:http://www.modularscale.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Multibase scale bug

equivalentideas opened this issue · comments

Using scale:

$ms-base: 1rem 1.0625rem;
$ms-ratio: $golden;

@debug ms-list(0, 2, $ms-base, $ms-ratio);

returns:

DEBUG: 1rem 1.0625rem 1.61803rem

but when calling scale 1 with:

font-size: ms(1);

The processed CSS appears as:

font-size: 1.61803rem;

In other words it's skipping to scale 2.

commented

The bug still exists on negative values

$ms-base: 1em 3.75em;
$ms-ratio: $fourth;

@debug ms-list(-2, 0, $ms-base, $ms-ratio);

returns:

DEBUG: 0.75em 0.88989em 1em

but when calling scale -1 with:

font-size: ms(-1);

The processed CSS appears as:

font-size: 0.75em

Same behavior, it's skipping to scale -2.

@equivalentideas, @DornieDortsch: How are you running modular scale? What version of Sass/libsass? Installed via Compass or another method?

unable to replicate in any version: http://sassmeister.com/gist/10592343

Sorry I should have closed this, I updated and this was no longer occurring. My bad, thanks @scottkellum :)

commented

Sorry for the late reply, but I run in the same error again. Negative values and multibase.

http://sassmeister.com/gist/41dbd8c5eccbf67de20a

reopening

This will be solved in 3.0.