modularscale / modularscale-sass

Modular scale calculator built into your Sass

Home Page:http://www.modularscale.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[enhancement] Add missing bower.json.

timgluz opened this issue · comments

Hey, maintainer(s) of Team-Sass/modular-scale!

We at VersionEye are working hard to keep up the quality of the bower's registry.

We just finished our initial analysis of the quality of the Bower.io registry:

7530 - registered packages, 224 of them doesnt exists anymore;

We analysed 7306 existing packages and 1070 of them don't have bower.json on the master branch ( that's where a Bower client pulls a data ).

Sadly, your library Team-Sass/modular-scale is one of them.

Can you spare 15 minutes to help us to make Bower better?

Just add a new file bower.json and change attributes.

{
  "name": "Team-Sass/modular-scale",
  "version": "1.0.0",
  "main": "path/to/main.css",
  "description": "please add it",
  "license": "Eclipse",
  "ignore": [
    ".jshintrc",
    "**/*.txt"
  ],
  "dependencies": {
    "<dependency_name>": "<semantic_version>",
    "<dependency_name>": "<Local_folder>",
    "<dependency_name>": "<package>"
  },
  "devDependencies": {
    "<test-framework-name>": "<version>"
  }
}

Read more about bower.json on the official spefication and nodejs semver library has great examples of proper versioning.

NB! Please validate your bower.json with jsonlint before commiting your updates.

Thank you!

Timo,
twitter: @versioneye
email: timo@versioneye.com
VersionEye - no more legacy software!

@timgluz This should be resolved now. Can you please add to the Bower docs that the branch in question must be the master. The default branch here was “2.0” not “master” and according to the Bower docs, Bower looks at the origin, not the “master” branch.

I made the naming changes here and created a new issue for you on Bower github: bower/bower#1035

Thanks.

default branch doesnt has to be master - it was my mistake - github resolves default_branch correctly and this isnt actually problem;