modrinth / theseus

Our game launcher which can be used as a CLI, GUI, and a library for creating and playing Modrinth projects.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Importing `client` & `server` overrides is not supported

juraj-hrivnak opened this issue · comments

Describe the bug

According to the Modrinth modpack format overrides can also be client-overrides and server-overrides.

However, theseus only imports overrides and client-overrides and server-overrides will get ignored.

Steps to reproduce

  • With a Modrinth modpack with this structure:
    modpack/
    ┣━━━ overrides/
    ┃    ┗━━━ mods/
    ┗━━━ client-overrides/
         ┣━━━ resourcepacks/
         ┗━━━ shaderpacks/
    
  • Click "Create profile"
  • Click "From File"
  • Import from file
  • Imported modpack will have this structure:
    modpack/
    ┗━━━ overrides/
         ┗━━━ mods/
    

Expected behavior

Both client-overrides and server-overrides should get imported according to the Modrinth modpack format in a layer-based approach.
So, overrides will get copied first, then client-overrides and server-overrides.

System information

No response

Additional context

No response