Giters

modelica / ModelicaStandardLibrary

Free (standard conforming) library to model mechanical (1D/3D), electrical (analog, digital, machines), magnetic, thermal, fluid, control systems and hierarchical state machines. Also numerical functions and functions for strings, files and streams are included.

Home Page:https://doc.modelica.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

MSL 4.1.0 Reference results Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_NoLoad

maltelenz opened this issue · comments

commented

After #4031 the reference signals for Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_NoLoad changed, so we need new reference results.

I also question why the test is not marked red in the report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica/testrun_report.html

commented

I also question why the test is not marked red in the report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica/testrun_report.html

To answer this question. It is marked as N/A since none of the new signal names

toPolar.y[1]
toPolar.y[2]
hallSensor.y

is available in https://github.com/modelica/MAP-LIB_ReferenceResults/blob/2be1c7e08a39d658b1326607917a0a32749e76e1/Modelica/Electrical/Machines/Examples/SynchronousMachines/SMPM_NoLoad/SMPM_NoLoad.csv

commented

That sounds serious enough to warrant red coloring, if the reference result doesn't even contain the variables one expects to test...

commented

Well, it is neither red nor green, but inclonclusive indicating that the comparison test could not be completed with the data available. There is yellow color also in other places used, e.g., if simulation time exceeds some threshold, I guess.

commented

Well, csv-compare writes a failed marker filer indeed: compare_failed.log whereas the report marks it as UNTESTED:

grafik

commented

We are only counting failed comparison.
Something, that can not be compared is not a failed comparison.

We can introduce a yellow instead of a gray field for this, if this makes you happy ...

commented

We can introduce a yellow instead of a gray field for this, if this makes you happy ...

That sounds better than gray. It is a serious issue with the test or regression result that needs solving, so it would be nice if the report can clearly mark it so it stands out.