MSL 4.1.0 Regressions - Mechanics.Rotational and Mechanics.Translational
GallLeo opened this issue · comments
The following models fail in result comparison.
Tested revision: f9bddf8 (2024-02-16)
Changed models, need reference update after library officer check:
-
Modelica.Mechanics.Rotational.Examples.EddyCurrentBrake
- Reason: The component has been enhanced in a backwards compatible way with an optional excitation input, which is demonstrated by this upgraded example. @GallLeo pls. create new reference results.
- Updated reference files? -
Modelica.Mechanics.Translational.Examples.EddyCurrentBrake
- Reason: The component has been enhanced in a backwards compatible way with an optional excitation input, which is demonstrated by this upgraded example. @GallLeo pls. create new reference results.
- Updated reference files? -
Release notes check: All classes mentioned which could lead to result changes in user models?
@GallLeo could you please feed the explanation to the release notes? Thx a lot!
Useful Links
Current comparison report:
https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html
-> Reference result test -> Comparison
Comparison signal definitions:
https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica
https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest
Reference results:
https://github.com/modelica/MAP-LIB_ReferenceResults
All three points fine to me.
@AHaumer after checking the points, you can please tick them all.
