Extract dockerfile2llb

Question

Extract dockerfile2llb

vdemeester opened this issue 7 years ago · comments

Vincent Demeester commented 7 years ago

The dockerfile2llb frontend shouldn't live in this repository. It should live somewhere in the docker organization.

This issue is here to keep track of the work on that.

Akihiro Suda · Answer 1 · Fri Dec 01 2017 11:05:17 GMT+0800 (China Standard Time)

Do we keep Dockerfile tests ( #183 ) in this repo after eliminating dockerfile2llb from this repo?

Tõnis Tiigi · Answer 2 · Sat Dec 02 2017 00:32:00 GMT+0800 (China Standard Time)

@AkihiroSuda I think tests in this repo should refer to a fixed version of dockerfile frontend and any update in this repo would check it out and also run dockerfile test suite. If some other frontends get popular we could do the same for them to make sure there are no accidental regressions.

Atm, I think we can keep adding tests to this repo and move them out together.

Vincent Demeester · Answer 3 · Sun Dec 03 2017 19:27:04 GMT+0800 (China Standard Time)

@AkihiroSuda I would think Dockerfile tests would move to the dockerfile2llb repository

Tõnis Tiigi · Answer 4 · Sat Dec 09 2017 09:49:40 GMT+0800 (China Standard Time)

We could start by moving github.com/moby/moby/builder/dockerfile/instructions github.com/moby/moby/builder/dockerfile/parser . For example, I would have liked to make a quick change for https://github.com/moby/buildkit/pull/196/files#diff-6f2add87df719e471c72e28c36caff8fR590 but moby implementation itself doesn't necessarily need it.