Stale package versions, TS errors in runtime and model code (with fixes)
jkolyer opened this issue · comments
This fork has fixed a number of issues found in the current codebase. It's not PR-ready yet, as it includes a workaround and isn't thoroughly tested.
The circular dependency workaround is a post-processing ruby script that consolidates all the base models into one file.
There are also fixes to deprecated TS, and other TS errors. Updates to package versions as well. The graphql version 15+ is not compatible with apollo 2, so it remains at 14. Apparently apollo 3 is in alpha.
Made some updates and added code comments. Still work-in-progress, but known TS errors resolved, including all circular dependencies.
@jkolyer when do you think this might get merged in?
I upgraded my TS and I'm getting errors in the reactUtils file.
I was thinking just to use patch-package to put a ts ignore in it. :/
The workaround I used does post-processing and is not a proper solution. To do this right will take me a couple of days effort, but I feel it's worthwhile. I'll try to squeeze it in over the next couple of weeks.
EDIT: I can do this is two stages, with bug fixes first, then fixing the circular dependencies (which will take longer). So probably by end of week I should have something ready.
@Aryk Created this PR with a minimum set of fixes. Note I haven't touched the examples. I tried to but realized I cannot confirm they will work properly since they don't all currently work properly. Perhaps a regular maintainer can clean those up with the new package versions.
HI @jkolyer Im going through all the open issues trying to help get things cleaned up and more organized. Can I close this issue?