Support for NG 9

Question

Support for NG 9

juan-fdz-hawa opened this issue 4 years ago · comments

Hi,

Excellent work with mobx-angular!

I was wondering if there are any plans for supporting NG 9 soon? If nothing is planned ATM, maybe I can help you guys with that :)?

Thanks

Egor Gorbachev · Answer 1 · Thu Jan 09 2020 23:42:53 GMT+0800 (China Standard Time)

Hi @juan-fdz-hawa
I am using mobx-angular extensively on production (with NG 7) and on a pet project with NG 9 (release candidate, because it is not released yet) and didn't encounter any issues. But feel free to test it on your own and report any issues.

Hi @adamkleingit
Travis CI supports build matrix to test a package against different environments, node versions, set of dependencies, etc: https://docs.travis-ci.com/user/build-matrix/
We can test mobx-angular against different angular versions on CI. What are your thoughts on it?

Juan Fernandez · Answer 2 · Thu Jan 09 2020 23:56:15 GMT+0800 (China Standard Time)

Updating from 3.0.1 to 3.0.3 solved the issue, thanks!

Adam Klein · Answer 3 · Fri Jan 10 2020 16:02:34 GMT+0800 (China Standard Time)

@kubk that's a fantastic idea. Do you want to create a PR for this?

Egor Gorbachev · Answer 4 · Fri Jan 10 2020 16:13:26 GMT+0800 (China Standard Time)

@adamkleingit Sure, I'll create a PR as soon as I have the time. Thank you.