Problem when canvas labels are not unique across items
pbinkley opened this issue · comments
We're using this code to support a project that is creating and harvesting IIIF annotations for a number of related objects: issues of a magazine. https://github.com/pbinkley/annotate . We've found that when two issues have a canvas with the same label (in our case simple integers), the annotations for the earliest issue will be displayed on the same page of subsequent issues. E.g. if you create annotations on issue 4 p. 127 and issue 6 p. 127, then the issue 4 annotations will be displayed when you view that page of issue 6. This is because the labels include only the canvas id and not the issue id:
I'll share a fix for this this week.
Hi @pbinkley. First off, I hope you are well and I'm glad this has been of some use! That said, this was really meant as a proof of concept awhile back, and I've known for some time that a lot of the code doesn't make as much sense as it should. I started writing a newer version when I was still at Columbia but didn't have the time to complete it.
With that preface, I'd be happy to collaborate on a newer version with you if you think it'd be worth it? Basically, I think I should either archive the repo or overhaul it entirely with some help. Incremental patches seem like more trouble than they're worth. Thoughts?
This has been a very handy utility for this project - we knew it was meant as a demo, and we've been able to make it do what we needed. I think our current project will wrap up before a new app could be built, but I'd love to collaborate on a new version - something with options for connecting to an external annotation store, and that works as part of a workflow to enhance and reuse other peoples' manifests. Could we pick this conversation up in a month or so? I'll have time then to think it through. (Or hey! If you're available for remote conversation on Oct. 2, maybe we could make this a whiteboard project at the Hackfest at the Access conference we're hosting https://accessconference.ca/workshops-and-hackfest/ - there's a Wax presentation on the program and probably another Wax group will form at Hackfest as well)
That all sounds great! I really am glad it has been of use. It's a good reminder for me to not let the perfect be the enemy of the good.
I don't think I'll have time Oct 2nd though this does look amazing. I'll let you know if something changes and I can participate. Regardless I'd love to hear how it goes! I know that folks are using Wax in the wild, but it's rare that I actually hear about it. Any feedback from your event would be really valuable.