Feature Request: make Google Translate and Google Text to Speech optimal dependencies
LuckyTurtleDev opened this issue · comments
I think many users did not need this features. Furthermore the associated packages python:googletrans and python:gtts are not part of many linux distributions.
It would also be much easier to create and maintain a mnemosyne package, so mnemosyne will hopeful be available at more distributions.
Some distribution like debian has already apply their own patches to disable this features.
Because of this I would be nice if this packages will be only optimal.
Whether or not many people use these features is of course a matter of debate :-)
I do believe it's the responsibility of the distributions here to take any actions they see fit, rather than Mnemosyne having to cater to the common denominator.
@pbienst Hi! Thanks for producing Mnemosyne :-)
I'm the maintainer for the Arch Linux AUR package. The issue we're having at the moment is that the googletrans package is broken, which unfortunately also means that users cannot install or use Mnemosyne, regardless of whether or not they want this functionality. Mnemosyne currently won't start without this package being present. It could most easily be made optional by turning this fatal error into a warning instead (i.e. wrapping the import googletrans in a try/except block. I'm happy to put in a PR if you don't have time.
I have created a pull request, which does make both optional: #201
Thanks, I have committed it, but I wouldn't be surprised if in the future we get support requests about why these features are not present, since there's not even a console warning message now...
I can add a warning, if you wish. That is no problem.
Thanks both. That's much appreciated.