White block at bottom of page with "night" skin

Question

White block at bottom of page with "night" skin

kubu4 opened this issue 6 years ago · comments

kubu4 commented 6 years ago

It renders this way when being locally served as well.

Environment

Basically Basic version: 1.4.1
Ruby gem or remote theme version:
Jekyll version:
Git repository URL: https://github.com/RobertsLab/sams-notebook
GitHub Pages hosted (if yes provide URL to site): https://robertslab.github.io/sams-notebook/
Operating system: Ubuntu 16.04
Browser: Firefox

Expected behavior

Expect solid background color for entire layout.

Michael Rose · Answer 1 · Fri Oct 26 2018 04:22:36 GMT+0800 (China Standard Time)

Did you modify the theme files at all when forking?

Because when I clone your repo, remove the duplicated _layouts, _includes, assets and _sass folders, install the theme as a remote theme by adding `remote_theme: "mmistakes/jekyll-theme-basically-basic" to _config.yml, everything looks correct.

The white box disappears. Which tells me there's something different in your fork from the default theme.

kubu4 · Answer 2 · Fri Oct 26 2018 05:41:58 GMT+0800 (China Standard Time)

Firstly, thanks so much for checking this out!

Did you modify the theme files at all when forking?

Unfortunately, I'm brand new to Jekyll, so I'm not hip to the lingo. I've modified some stuff, but I'm not sure which files constitute "theme files". So, the answer is: probably.

remove the duplicated _layouts, _includes, assets and _sass folders

Which duplicates? When I look in my repo, I only see those folders in the root directory. Are you referring to removing the "duplicates" found in /example/*?

Or, are you saying you performed the following steps:

Delete existing folders mentioned above.
Add remote_theme: "mmistakes/jekyll-theme-basically-basic" to _config.yml.
Build site (or, push to GitHub).

Michael Rose · Answer 3 · Fri Oct 26 2018 07:34:31 GMT+0800 (China Standard Time)

By theme files I mean everything in the _layouts, _includes, _sass and assets folders. Looks like you directly copied all of them from theme's repo. This is fine, but it's better to remove all of those folders/files and install as a remote_theme.

Doing it this way you can upgrade without needing to copy over files from the theme. By "duplicates" i was referring to those folders. I would suggest you remove them all as it looks like you modified something in one of the layouts that broke the layout.

You can remove example/ and docs/ as well since those are used for testing and the demo site.
Add remote_theme: "mmistakes/jekyll-theme-basically-basic" to _config.yml.

Replace the contents of Gemfile with:

source "https://rubygems.org"
gem "github-pages", group: :jekyll_plugins

Run bundle install

Doing this you can build the site locally using the exact same gems GitHub Pages does. This is good to test that everything is working as expected before pushing up to GitHub for them to host your site.

kubu4 · Answer 4 · Sat Oct 27 2018 05:56:09 GMT+0800 (China Standard Time)

Thanks! This definitely resolves the issue!

However, now that I don't have those folders any more, two quick questions:

If I'd like to change the font that's used throughout the site, what do I do?
How does the site render without those folders?

Michael Rose · Answer 5 · Mon Oct 29 2018 20:20:51 GMT+0800 (China Standard Time)

Have a look over Jekyll's docs on how themes work. When you install as a Ruby gem or remote theme those folders won't be in your repo anymore. They are pulled down and managed elsewhere to make updating easier.

The only reason you'd want to keep copies of these theme file in your repo is if you are overriding them.

If you want to change the font you can do so here, and then you'll need to change the CSS. Add any Sass variable changes or other declarations to this file. It will override what is bundled in the theme.