Deprecation of / as division operator in dart sass 2.0
lizsugar opened this issue · comments
Environment
- Basically Basic version: 1.4.5
- Ruby gem or remote theme version: ruby gem
- Jekyll version: 4.3.1
- Operating system: Windows and Linux
Expected behavior
A smooth clean site build without any issues
Steps to reproduce the behavior
Running bundle exec jekyll build results in errors being thrown regarding the / operator being deprecated.
I have attempted to resolve these issues on https://github.com/lizsugar/jekyll-theme-basically-basic/tree/dart-sass-2.0-updates, which now builds a site without errors. However, I now end up with the font scaling no longer working right.
How it looks before / is turned into math.div():
How it looks afterwards:
I'm not familiar enough with the project to understand exactly how it was doing that scaling before. If someone could help me out here, that'd be super great :)
Most of what I’m seeing in the output are warnings about Sass deprecations. The Sass in this project isn’t compatible with Dart Sass as it’s quite old so that’s likely why you’re seeing warnings and issues.
Jekyll has some notes about it, you may need to use the older (and deprecated) Ruby Sass.
https://jekyllrb.com/news/2022/12/21/jekyll-sass-converter-3.0-released/
Here’s an issue on how to lock Jekyll’s Sass converter gem to the older version which should hopefully get around the errors.
jekyll/jekyll-sass-converter#145 (comment)
Other than that the Sass partials would need to be refactored to support Dart Sass which isn’t something I will be getting to anytime soon.
As far as the fluid type partial. More context there on its inner workings can be found here:
https://www.madebymike.com.au/writing/fluid-type-calc-examples/
Even better lol. Thank you so much for the quick response!