Menu is vertical (mobile-style) in Firefox < 22
mlms13 opened this issue · comments
The Problem
I think autoprefixer has determined that the market share of Firefox < 22 is small enough that it doesn't need to add -moz- prefixes for the old flexbox syntax. You can see proof of that in the compiled css.
This would be fine, as it should gracefully fall back to display: table. However, elsewhere in the code we're making the assumption that we support all browsers that match Modernizr's test for flexboxlegacy, and we're wiping out the display: table-cell.
The Solution?
If we're going to let Modernizr assume that we're supporting flexboxlegacy I guess we really do need to support all of flexbox legacy. We should be able to configure autoprefixer to support older versions of Firefox by setting some options in our Grunt build.
Any other options?
Did we come to the conclusion that this wasn't worth fixing since it's currently in the lesser of two evils category? I believe that wiping out the display: table-cell was to fix new versions of Firefox and iOS/Safari for Windows. And if that's the case (I forget since it's been a while), I don't think old Firefox is a priority.
I think the only solution we came up with was to make all of Firefox fall back to display: table and not use flexbox at all since it was not overriding display: table like it should be.
What do you think? Worth it?