Promote typo in UI source (pomote -> promote, Pomote -> Promote)
bwalheim1205 opened this issue · comments
Summary
Description
There are 6 small typos in 3 UI source code files where it references pomote/Pomote instead of promote/Promote. None of these changes are user facing just in the source code.
Files with typos
- mlflow/server/js/src/i18n/default/en.json (Ln 16, 2312)
- mlflow/server/js/src/model-registry/components/ModelVersionView.tsx (Ln 476, 498)
- mlflow/server/js/src/model-registry/components/PromoteModelButton.tsx (Ln 173, 180)
Notes
-
Make sure to open a PR from a non-master branch.
-
Sign off the commit using the
-s
flag when making a commit:git commit -s -m "..." # ^^ make sure to use this
-
Include
#{issue_number}
(e.g.#123
) in the PR description when opening a PR.
@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.
Shouldn't this issue be closed?
is this issue still open?
I believe it has not been addressed yet. Looks like my PR with fix has fallen behind main and now has conflict. I can rebase the PR later today
#12405 has been rebased onto main to resolve conflicts. It should address this issue for english typo