Missing tag in some svg files.
khamsolt opened this issue · comments
Assalam alaikum. In the countries I have listed:
HUN LCA SOM NLC GBR CAF GMB GUF HUM IND LBR LCA MAC MKD NLD PLW ROU SOM SYR TLS UKR WLF
The flags of these countries are missing tags
<?xml version="1.0" encoding="UTF-8"?>
Should I count on fixing this error in the near future? And thanks for the awesome package.
@mledoze hi, I need your help...
@khamsolt fork the repo and change it at your heart content is the easiest way
@cumanacr I need this package within another package (https://github.com/antonioribeiro/countries).
Maybe you must fork antonioribeiro/countries package then, change the svg flags in directory countries/src/data/flags instead. That directory hasn't been updated in years, that is what I would do if I was in your place
@cumanacr thanks for the advice, but our team tried just that. Here is our issue, however, the author pointed us to a data update script. This script downloads your package, moves files from there. Therefore, we are trying to add these changes here. Due to the fact that this tag is missing, we cannot show them in the browser, the browser is trying to download them. Please take a look at the merge request.
It's not my package I wrote an issue in 2015 and that's all ¯_(ツ)_/¯
I cannot merge anything, sorry
Wait for @mledoze he will check your pull request don't worry just be patient
Regards, over and out
@cumanacr Thank you, I decided if you are on the maintainer list then you can merge branches =) Sorry
Fixed by #420