Giters

mlcommons / inference

Reference implementations of MLPerf™ inference benchmarks

Home Page:https://mlcommons.org/en/groups/inference

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

LoadGen compilation warnings

szutenberg opened this issue · comments

commented

New token_latencies feature has introduced some complication warnings:

x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c bindings/python_api.cc -o build/temp.linux-x86_64-cpython-310/bindings/python_api.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c early_stopping.cc -o build/temp.linux-x86_64-cpython-310/early_stopping.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c generated/version_generated.cc -o build/temp.linux-x86_64-cpython-310/generated/version_generated.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c issue_query_controller.cc -o build/temp.linux-x86_64-cpython-310/issue_query_controller.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c loadgen.cc -o build/temp.linux-x86_64-cpython-310/loadgen.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c logging.cc -o build/temp.linux-x86_64-cpython-310/logging.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c results.cc -o build/temp.linux-x86_64-cpython-310/results.o -std=c++17 -fvisibility=hidden -g0
results.cc: In member function ‘bool mlperf::loadgen::PerformanceSummary::PerfConstraintsMet(std::string*)’:
results.cc:346:61: warning: comparison of integer expressions of different signedness: ‘mlperf::QuerySampleLatency’ {aka ‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  346 |         if ( token_target_latency_percentile.sample_latency >
      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  347 |             settings.server_ttft_latency) {
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~                     
results.cc:352:52: warning: comparison of integer expressions of different signedness: ‘mlperf::QuerySampleLatency’ {aka ‘long int’} and ‘uint64_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  352 |         if ( target_tpot_percentile.sample_latency >
      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
  353 |             settings.server_tpot_latency) {
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~            
results.cc: In member function ‘void mlperf::loadgen::PerformanceSummary::LogSummary(mlperf::loadgen::AsyncSummary&)’:
results.cc:416:12: warning: enumeration value ‘Server’ not handled in switch [-Wswitch]
  416 |     switch (settings.scenario) {
      |            ^
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c test_settings_internal.cc -o build/temp.linux-x86_64-cpython-310/test_settings_internal.o -std=c++17 -fvisibility=hidden -g0
test_settings_internal.cc: In member function ‘int mlperf::TestSettings::FromConfig(const string&, const string&, const string&)’:
test_settings_internal.cc:693:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  693 |   if (lookupkv(model, scenario, "use_token_latencies", &val, nullptr))
      |   ^~
test_settings_internal.cc:695:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  695 |     if (use_token_latencies){
      |     ^~
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c utils.cc -o build/temp.linux-x86_64-cpython-310/utils.o -std=c++17 -fvisibility=hidden -g0
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -std=c++14 -O3 -fPIC -DMAJOR_VERSION=4 -DMINOR_VERSION=0 -I. -I/usr/local/lib/python3.10/dist-packages/pybind11/include -I/root/<REDACTED>/include -I/usr/include/python3.10 -c version.cc -o build/temp.linux-x86_64-cpython-310/version.o -std=c++17 -fvisibility=hidden -g0
creating build/lib.linux-x86_64-cpython-310
x86_64-linux-gnu-g++ -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -g -fwrapv -O2 -std=c++14 -O3 build/temp.linux-x86_64-cpython-310/bindings/python_api.o build/temp.linux-x86_64-cpython-310/early_stopping.o build/temp.linux-x86_64-cpython-310/generated/version_generated.o build/temp.linux-x86_64-cpython-310/issue_query_controller.o build/temp.linux-x86_64-cpython-310/loadgen.o build/temp.linux-x86_64-cpython-310/logging.o build/temp.linux-x86_64-cpython-310/results.o build/temp.linux-x86_64-cpython-310/test_settings_internal.o build/temp.linux-x86_64-cpython-310/utils.o build/temp.linux-x86_64-cpython-310/version.o -L/usr/lib/x86_64-linux-gnu -o build/lib.linux-x86_64-cpython-310/mlperf_loadgen.cpython-310-x86_64-linux-gnu.so
/root/<REDACTED>/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(

CC @pgmpablo157321

commented

@szutenberg shall we modify the github action to fail on any compilation warning? Probably for 4.1

commented

@arjunsuresh Good idea!

I have tested #1608 . The issue can be closed once the fix is merged.