Support for other cryptos?

Question

Support for other cryptos?

nabbl opened this issue 5 years ago · comments

Daniel Kappler commented 5 years ago

Great module!

How about supporting more currencies on Coinbase?

Mathis Le Bonniec · Answer 1 · Tue Jul 30 2019 05:01:36 GMT+0800 (China Standard Time)

Thank you so much !

For the moment it's impossible, I will see in the future.

Daniel Kappler · Answer 2 · Wed Jul 31 2019 18:59:53 GMT+0800 (China Standard Time)

@mlbonniec can you please add me as a maintainer as well? I implemented this myself and want to create a pull request for you to review.

Mathis Le Bonniec · Answer 3 · Wed Jul 31 2019 19:53:16 GMT+0800 (China Standard Time)

@mlbonniec can you please add me as a maintainer as well? I implemented this myself and want to create a pull request for you to review.

To add you as maintainer I have to create a team, and I don't really want to create one just for that...
Normally you can create a pull request without being maintainer

Daniel Kappler · Answer 4 · Wed Jul 31 2019 20:00:13 GMT+0800 (China Standard Time)

I lack permissions to push a new branch however...
https://help.github.com/en/articles/inviting-collaborators-to-a-personal-repository

Mathis Le Bonniec · Answer 5 · Wed Jul 31 2019 20:05:53 GMT+0800 (China Standard Time)

Normally it's good ;-)

Mathis Le Bonniec · Answer 6 · Wed Jul 31 2019 20:41:24 GMT+0800 (China Standard Time)

Whooo, thanks for your incredible work!
I must admit that I am no longer really motivated by this module, so your help is really valuable!
I added you to the contributors, at the bottom of the README.md

Daniel Kappler · Answer 7 · Wed Jul 31 2019 20:43:07 GMT+0800 (China Standard Time)

Thx mate. I was only motivated because I have litecoins and no bitcoins. ;)

Mathis Le Bonniec · Answer 8 · Wed Jul 31 2019 20:44:56 GMT+0800 (China Standard Time)

ahaha it all makes sense 😆