mkovatsc / Copper

Copper (Cu) CoAP user-agent (JavaScript implementation)

Home Page:http://people.inf.ethz.ch/mkovatsc/copper.php

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

feature suggestion: cbor

chrysn opened this issue · comments

with cbor being present in newer versions of senml, in the core-links-json draft and the yang-cbor-mapping, it is likely to be present in many upcoming debugging situations in which copper is used.

libraries for decoding cbor in javascript already exist.

cbor could be visualized in the "Rendered" tab just as json is.

I know, there is even an open pull-request (Oic dev #13) from last year that I did not have the time to review yet (shame on me! :) ).

It would be helpful to split #13 up into multiple PRs, so I can merge individual features, since it is much easier to to decide and also review...

Yes, the pull request adds multiple new functionalities which are all integrated together on this single (oic_dev) branch. But because the feature patches are successive patches, the integration order of the patches may be important to avoid merge conflicts. Is it feasible for you to cherry pick the patches one by one to ease the review?

Partially merged @stephanesan 's PR in 1.0.1 -- thanks!
BTW: coap://californium.eclipse.org:5683/multi-format now also offers CBOR.