mkhazov / videojs-share

Share plugin for video.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

.vjs-share is applied to the entire player

Discookie opened this issue · comments

Discussed further in iv-org/invidious#160.

Fanboy's Social Blocking and Fanboy's Annoyance List block the class .vjs-share.

This class is applied to the entire video frame here, along with .vjs-videojs-share:

this.player.ready(() => {
this.player.addClass('vjs-share');
player.addClass('vjs-videojs-share');
player.getChild('controlBar').addChild('ShareButton', options);
player.addChild('ShareOverlay', options);
});

But later you only make use of .vjs-videojs-share on the frame, while using .vjs-share for the button.

And thus the entire player is blocked, instead of only the share button.

Appears to be fixed using the latest version of Fanboy's Social Blocking and Fanboy's Annoyance List. Both now contain this line:

/videojs-share.

Which blocks assets for this plugin, so the player still works as normal. I believe this can be closed.