DatetimeSelectInput appears to be broken
vincentwoo opened this issue · comments
After installing formtastic-bootstrap according to the readme (gem, css, initializer) I get an error with the following code
<%= semantic_form_for current_user do |f| %>
<%= f.input :end_time %>
<% end %>
user.end_time is a DateTime. It does something weird with fragment_placeholder for the string 'year'. I should also note that I am on Rails 4 (beta 1) and ruby 2.0.0-p0.
04:46:52 log.1 | TypeError - no implicit conversion of nil into String:
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:49:in `fragment_placeholder'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:33:in `block in fragment_input_html_options'
04:46:52 log.1 | (gem) andand-1.3.3/lib/andand.rb:60:in `me'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:30:in `fragment_input_html_options'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:26:in `fragment_input_html'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:12:in `block (3 levels) in to_html'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:11:in `block (2 levels) in to_html'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:38:in `block in capture'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:200:in `with_output_buffer'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:38:in `capture'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/wrapping.rb:31:in `controls_wrapping'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:9:in `block in to_html'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:38:in `block in capture'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:200:in `with_output_buffer'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:38:in `capture'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/wrapping.rb:25:in `control_group_wrapping'
04:46:52 log.1 | (gem) formtastic-bootstrap-2.0.0/lib/formtastic-bootstrap/inputs/base/timeish.rb:7:in `to_html'
04:46:52 log.1 | (gem) formtastic-2.2.1/lib/formtastic/helpers/input_helper.rb:240:in `input'
04:46:52 log.1 | app/views/users/show.html.erb:6:in `block in _app_views_users_show_html_erb__1818619761525654053_70131809307920'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:38:in `block in capture'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:200:in `with_output_buffer'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/capture_helper.rb:38:in `capture'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/helpers/form_helper.rb:435:in `form_for'
04:46:52 log.1 | (gem) formtastic-2.2.1/lib/formtastic/helpers/form_helper.rb:161:in `block in semantic_form_for'
04:46:52 log.1 | (gem) formtastic-2.2.1/lib/formtastic/helpers/form_helper.rb:192:in `with_custom_field_error_proc'
04:46:52 log.1 | (gem) formtastic-2.2.1/lib/formtastic/helpers/form_helper.rb:160:in `semantic_form_for'
04:46:52 log.1 | app/views/users/show.html.erb:5:in `_app_views_users_show_html_erb__1818619761525654053_70131809307920'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/template.rb:143:in `block in render'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications.rb:160:in `instrument'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/template.rb:141:in `render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/template_renderer.rb:49:in `block (2 levels) in render_template'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/abstract_renderer.rb:23:in `block in instrument'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications.rb:158:in `block in instrument'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications.rb:158:in `instrument'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/abstract_renderer.rb:23:in `instrument'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/template_renderer.rb:48:in `block in render_template'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/template_renderer.rb:56:in `render_with_layout'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/template_renderer.rb:47:in `render_template'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/template_renderer.rb:17:in `render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/renderer.rb:36:in `render_template'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_view/renderer/renderer.rb:17:in `render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/rendering.rb:119:in `_render_template'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/streaming.rb:219:in `_render_template'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/rendering.rb:112:in `render_to_body'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/rendering.rb:33:in `render_to_body'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/renderers.rb:26:in `render_to_body'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/rendering.rb:97:in `render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/rendering.rb:16:in `render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/instrumentation.rb:41:in `block (2 levels) in render'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/core_ext/benchmark.rb:5:in `block in ms'
04:46:52 log.1 | /Users/vincentwoo/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/benchmark.rb:296:in `realtime'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/core_ext/benchmark.rb:5:in `ms'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/instrumentation.rb:41:in `block in render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/instrumentation.rb:84:in `cleanup_view_runtime'
04:46:52 log.1 | (gem) activerecord-4.0.0.beta1/lib/active_record/railties/controller_runtime.rb:24:in `cleanup_view_runtime'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/instrumentation.rb:40:in `render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/implicit_render.rb:10:in `default_render'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/implicit_render.rb:5:in `send_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/base.rb:189:in `process_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/rendering.rb:10:in `process_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/callbacks.rb:18:in `block in process_action'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/callbacks.rb:383:in `_run__878521350067367672__process_action__callbacks'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/callbacks.rb:78:in `run_callbacks'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/callbacks.rb:17:in `process_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/rescue.rb:29:in `process_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/instrumentation.rb:31:in `block in process_action'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications.rb:158:in `block in instrument'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/notifications.rb:158:in `instrument'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
04:46:52 log.1 | (gem) activerecord-4.0.0.beta1/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/base.rb:136:in `process'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/abstract_controller/rendering.rb:44:in `process'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal.rb:196:in `dispatch'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_controller/metal.rb:232:in `block in action'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/routing/route_set.rb:78:in `dispatch'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/routing/route_set.rb:46:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/journey/router.rb:69:in `block in call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/journey/router.rb:57:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/routing/route_set.rb:651:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/etag.rb:23:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/conditionalget.rb:25:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/head.rb:11:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/flash.rb:241:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/session/abstract/id.rb:225:in `context'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/session/abstract/id.rb:220:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/cookies.rb:452:in `call'
04:46:52 log.1 | (gem) activerecord-4.0.0.beta1/lib/active_record/query_cache.rb:36:in `call'
04:46:52 log.1 | (gem) activerecord-4.0.0.beta1/lib/active_record/connection_adapters/abstract/connection_pool.rb:632:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/callbacks.rb:373:in `_run__3051430443707796577__call__callbacks'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/callbacks.rb:78:in `run_callbacks'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/reloader.rb:64:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/remote_ip.rb:76:in `call'
04:46:52 log.1 | (gem) better_errors-0.7.2/lib/better_errors/middleware.rb:84:in `protected_app_call'
04:46:52 log.1 | (gem) better_errors-0.7.2/lib/better_errors/middleware.rb:79:in `better_errors_call'
04:46:52 log.1 | (gem) better_errors-0.7.2/lib/better_errors/middleware.rb:56:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
04:46:52 log.1 | (gem) railties-4.0.0.beta1/lib/rails/rack/logger.rb:38:in `call_app'
04:46:52 log.1 | (gem) railties-4.0.0.beta1/lib/rails/rack/logger.rb:21:in `block in call'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/tagged_logging.rb:67:in `block in tagged'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/tagged_logging.rb:25:in `tagged'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/tagged_logging.rb:67:in `tagged'
04:46:52 log.1 | (gem) railties-4.0.0.beta1/lib/rails/rack/logger.rb:21:in `call'
04:46:52 log.1 | (gem) quiet_assets-1.0.2/lib/quiet_assets.rb:18:in `call_with_quiet_assets'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/request_id.rb:21:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/methodoverride.rb:21:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/runtime.rb:17:in `call'
04:46:52 log.1 | (gem) activesupport-4.0.0.beta1/lib/active_support/cache/strategy/local_cache.rb:72:in `call'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/lock.rb:17:in `call'
04:46:52 log.1 | (gem) actionpack-4.0.0.beta1/lib/action_dispatch/middleware/static.rb:64:in `call'
04:46:52 log.1 | (gem) railties-4.0.0.beta1/lib/rails/engine.rb:510:in `call'
04:46:52 log.1 | (gem) railties-4.0.0.beta1/lib/rails/application.rb:96:in `call'
04:46:52 log.1 | (gem) railties-4.0.0.beta1/lib/rails/railtie/configurable.rb:30:in `method_missing'
04:46:52 log.1 | (gem) rack-1.5.2/lib/rack/deflater.rb:25:in `call'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/connection.rb:81:in `block in pre_process'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/connection.rb:79:in `pre_process'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/connection.rb:54:in `process'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/connection.rb:39:in `receive_data'
04:46:52 log.1 | (gem) eventmachine-1.0.3/lib/eventmachine.rb:187:in `run'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/backends/base.rb:63:in `start'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/server.rb:159:in `start'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/controllers/controller.rb:86:in `start'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/runner.rb:187:in `run_command'
04:46:52 log.1 | (gem) thin-1.5.0/lib/thin/runner.rb:152:in `run!'
04:46:52 log.1 | (gem) thin-1.5.0/bin/thin:6:in `<top (required)>'
04:46:52 log.1 | /Users/vincentwoo/.rvm/gems/ruby-2.0.0-p0/bin/thin:23:in `<main>'
04:46:52 log.1 | /Users/vincentwoo/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `<main>'
Please do investigate, and let me know if anything in formtastic-bootstrap needs to be changed. Thanks!
Hi, I get "no implicit conversion of nil into String:" error for :date type if I use formtastic-bootstrap.
I have a form with an input like this:
f.input :birthday
If I turn off formtastic-bootstrap gem and initializer, then formtastic is working properly. So formtastic-bootstrap could cause this error, I guess.
I proposed a fix for this issue. It as been corrected in Formastic master branch but they didn't build a new version including this commit. I hope it will help !
@jameslafa Will your PR #72 resolve this issue? -- What's the potential fallout for Rails 3.x users?
Yes, it solves this issue. I did not tried on Rails 3.x but I'm just converting a string to symbol if it is not a symbol already. In every case, you need a symbol to find the fragment as explained in my pull request so I guess it won't create any problem. But it would be better to check it just in case I missed something.
Fixed in formtastic-bootstrap 2.1.2. Thank you!
My pleasure !
Thanks for your gem and for helping me with this pull request :)