Giters

mittwald / go-helm-client

Go client for accessing the Helm package manager

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

just want to ask a question ?

nxtcoder17 opened this issue · comments

commented

Hi guys,

currently this project suffers from this problem #104, which more or less leaves only one choice to create new helm clients for each namespaces over which you want to release a chart.

I forked this repo, and made some changes to accomodate that behaviour, because i needed to deploy this client in a k8s reconciler and could not have afforded creating new client on every reconcilation loop.

If you guys think, that should be an acceptable behaviour, then i can drop a pull request with the fix ?

My Observations

Basically, the issues comes up when we create HelmClient without specifying a namespace, refer here

screenshot-9536

followed by this, we have created actionConfig (using the above defined clientGetter), and the same actionConfig is used to perform all the helm operations. refer here

screenshot-26885

AND this exact thing disallows us from applying charts to the specified chartspec.namespace)

I just broke that behaviour, created actionConfig (along with clientGetter) lazily, wherever they are required, like as in (helmclient.install, or helmclient.update calls). And it works ...