Giters

mitchellkrogza / nginx-ultimate-bad-bot-blocker

Nginx Block Bad Bots, Spam Referrer Blocker, Vulnerability Scanners, User-Agents, Malware, Adware, Ransomware, Malicious Sites, with anti-DDOS, Wordpress Theme Detector Blocking and Fail2Ban Jail for Repeat Offenders

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Doesn't add includes to every server directive in a config file

fluffy-critter opened this issue · comments

commented

Describe the bug

Sometimes a server configuration will have multiple declared server blocks within a config file, for example having separate configurations for multiple related subdomains. setup-ngxblocker seems to assume that only the bottommost server directive needs to be modified.

To Reproduce

Steps to reproduce the behavior:

  1. Have a configured site with multiple subdomain configurations in a single .conf
  2. Run setup-ngxblocker

Expected behavior

Every server block should have the ngxblocker configuration includes.

Server (please complete the following information):

  • Operating System:

  • Ubuntu

  • Alpine

  • Arch Linux

  • Debian

  • CentOS

  • Fedora

  • Deepin

  • Windows

  • Other

  • Specify Exact Version of OS:


Linux nautilus.e-snail.us 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
  • Nginx Version [post output of sudo nginx -v]

nginx version: nginx/1.18.0 (Ubuntu)

  • Other Environments [include Version information]

  • Plesk

  • CPanel

  • Synology NAS

  • Other

  • Specify Other / Specific Version Information Here:

  • Any other applicable log / error messages that may help us to help you.


Paste any log / error messages here (paste in between the ```     ``` markers)

Additional information

Add any other context about the problem here.

commented

Actually it looks like I was incorrect, it's actually failing to add configuration to my sites that use proxy_pass. I'm guessing I need to consult the docs more thoroughly.