Missing conditional

[Loic Nageleisen]

I started from latest NixOS 22.05.926.8b538fcb329. Seems like vmware-user-suid-wrapper is missing, which makes it bail out:

Checking that Nix store paths of all wrapped programs exist... FAIL
The path /nix/store/4nr8h0y47xn8vpb4llv7fj2nbjn0pwg8-open-vm-tools-12.0.0/bin/vmware-user-suid-wrapper does not exist!
Please, check the value of `security.wrappers."vmware-user-suid-wrapper".source`.
Adding hwdb files for package /nix/store/vb55ph7qmjj85lfaa709jlxllvfpfb6j-systemd-250.4
Adding rules for package /nix/store/4nr8h0y47xn8vpb4llv7fj2nbjn0pwg8-open-vm-tools-12.0.0

error: builder for '/nix/store/yhv7v1k132zrqqdzl7cz30p5zxrm1ffp-ensure-all-wrappers-paths-exist.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/g132qpgx4lr5bl5vfv6x6vm5rgx4qf5z-nixos-system-nixos-22.05.926.8b538fcb329.drv' failed to build

Indeed:

$ ls /nix/store/4nr8h0y47xn8vpb4llv7fj2nbjn0pwg8-open-vm-tools-12.0.0/bin/
vmhgfs-fuse  vmware-checkvm     vmware-namespace-cmd  vmware-toolbox-cmd   vmware-xferlogs
vmtoolsd     vmware-hgfsclient  vmware-rpctool        vmware-vmblock-fuse  vmwgfxctrl

In any case it feels like there's a missing mkIf (!cfg.headless) conditional since IIRC its only use is for X?

    security.wrappers.vmware-user-suid-wrapper = mkIf (!cfg.headless) {
      setuid = true;
      owner = "root";
      group = "root";
      source = "${open-vm-tools}/bin/vmware-user-suid-wrapper";
    };

And with that I was good to go with my headless setup.