bedrock2 tip does not build on Coq master
JasonGross opened this issue · comments
How do you guys run CI on your commits before pushing them to master?
I am building bedrock2 to investigate this issue.
I think no MIT projects have pre-merge CI right now. My apologies for the inconvenience this causes to you.
I think no MIT projects have pre-merge CI right now. My apologies for the inconvenience this causes to you.
Note that pre-merge testing is a requirement of the Coq CI policy: https://github.com/coq/coq/blob/master/dev/ci/README-users.md
Setting up a CI is recommended, testing is required. But you do have a CI, it seems, right?
Cc @coq/ci-maintainers
We have a CI because I (incorrectly) thought that this (plus best effort to fix breakage) was the requirement to be on coq CI.
As another data point: In fiat-crypto and rewriter, I will generally make PRs for anything that I think has a chance of breaking on some Coq versions but not others, and will only merge once the CI passes. (Sometimes typos slip through, or what I think to be a small fix ends up breaking something.)