[Open tasks] Replace storyboards with code

Question

[Open tasks] Replace storyboards with code

misteu opened this issue 2 years ago · comments

Michael Steudter commented 2 years ago

GOAL

Replace all the storyboards with UIs created via code.

For not having one really huge branch, this will be split up in issues on a screen basis!

If you are interested in working on some screen, please comment on any of the open subtasks listed below.

Subtasks

NewLanguageViewController
#17
HomeScreenViewController
#20
LanguageScreenViewController
#21
AddNewWordViewController
#22
(Final issue) Remove any Main.storyboard references from the project, update AppDelegate.

WHY

Storyboards are slow to load in Xcode and they are harder to maintain compared to plain code.

AC

There should not be any storyboards in the app.
Optional
First choice would be UIKit. It might make sense to also have a look whether it might make sense to start rewriting screens using SwiftUI. However, this will be way more work as it's a rewrite of everything.

Michael Steudter commented 2 years ago

all done!

Harsh M. Yadav · Answer 1 · Sat Oct 01 2022 03:05:42 GMT+0800 (China Standard Time)

Hi @misteu, I would like to work on this issue.

Michael Steudter · Answer 2 · Sat Oct 01 2022 15:56:18 GMT+0800 (China Standard Time)

Hi @misteu, I would like to work on this issue.

Hi @InsanelyHarsh!
Thank you for your interest in the project :)

Please tell me which screen you want to translate into code. I will create an issue and assign it to you.

Have a great weekend!

Harsh M. Yadav · Answer 3 · Sat Oct 01 2022 19:56:25 GMT+0800 (China Standard Time)

I think i will start with Add new Language View

Harsh M. Yadav · Answer 4 · Sat Oct 01 2022 22:16:23 GMT+0800 (China Standard Time)

Assign me, I have replaced NewLanguageViewController with Code!

Michael Steudter · Answer 5 · Sun Oct 02 2022 02:33:59 GMT+0800 (China Standard Time)

Assign me, I have replaced NewLanguageViewController with Code!

Hi there and thank you!
I created this issue for the specific View Controller you worked on:
#17 (I think you need to comment there so that I can assign it to you)

Kanishka C · Answer 6 · Fri Oct 28 2022 02:25:27 GMT+0800 (China Standard Time)

I am taking up the HomeScreenViewController.

Michael Steudter · Answer 7 · Fri Oct 28 2022 02:51:52 GMT+0800 (China Standard Time)

Hi @Kanishka3 !
thanks for your interest! :)

Can you comment inside of the issue for this screen (#20)? I will assign it to you then.

Actually, it is already assigned to somebody else but I don't think there wasn't any work done yet.

Please comment there and maybe let's wait until tomorrow if he reacts.

Kanishka C · Answer 8 · Fri Oct 28 2022 05:07:30 GMT+0800 (China Standard Time)

Hi @Kanishka3 ! thanks for your interest! :)

Can you comment inside of the issue for this screen (#20)? I will assign it to you then.

Actually, it is already assigned to somebody else but I don't think there wasn't any work done yet.

Please comment there and maybe let's wait until tomorrow if he reacts.

Alright. Replies there. I am almost halfway done with the task.