misode / mcmeta

Processed, version controlled history of Minecraft's generated data and assets

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Summary: 1.14.1 and 1.14 aren't marked as stable

MMK21Hub opened this issue · comments

Affected file: Version data JSON file in the summary branch

Relevent lines: 2499 and 2541

  {
    "id": "1.14",
    "name": "1.14",
    "release_target": "1.14",
    "type": "release",
    "stable": false, // HERE
    "data_version": 1952,
    "protocol_version": 477,
    "data_pack_version": 4,
    "resource_pack_version": 4,
    "build_time": "2019-04-23T14:51:09+00:00",
    "release_time": "2019-04-23T14:52:44+00:00",
    "sha1": "44552c5e051cff06483616adb1f6fd2d94ee3447"
  },
  ...
  {
    "id": "1.14.1",
    "name": "1.14.1",
    "release_target": "1.14.1",
    "type": "release",
    "stable": false, // HERE
    "data_version": 1957,
    "protocol_version": 480,
    "data_pack_version": 4,
    "resource_pack_version": 4,
    "build_time": "2019-05-13T11:08:37+00:00",
    "release_time": "2019-05-13T11:10:12+00:00",
    "sha1": "770df8fddfd27061560507267eccb650345b61e2"
  },

This data comes straight from Mojang, if you follow the version manifest, download the server jar and extract version.json.

{
    "id": "1.14 / 5dac5567e13e46bdb0c1d90aa8d8b3f7",
    "name": "1.14",
    "release_target": "1.14",
    "world_version": 1952,
    "protocol_version": 477,
    "pack_version": 4,
    "build_time": "2019-04-23T14:51:09+00:00",
    "stable": false
}

I'm not sure what's up with it. Do you think this should be manually fixed? (Just like some version ID inconsistencies have been fixed https://github.com/misode/mcmeta/blob/main/main.py#L43)

Hmm, that's odd. I think that old version IDs are more important than the stable field on a couple of versions, so it's probably fine just to leave it alone.

To be honest, I'm not sure what the difference is between checking the stable field and checking if type === "release", but maybe it makes sense within the context of a server.

Yeah I don't know the difference either