mirage / ocaml-cohttp

An OCaml library for HTTP clients and servers using Lwt or Async

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Please backport to v4 support for cmdliner >= 1.2.0

glondu opened this issue · comments

At the moment, in my environment, I'm still getting ocaml-cohttp 4.0.0 which is vulnerable to the issue fixed by c9c1e60. It seems to be due to a conflict with cmdliner 1.2.0. Please consider backporting support for cmdliner >= 1.2.0 and making a release in the 4.x series.

I'm stuck to 4.x because of ocsigenserver. Cf ocsigen/ocsigenserver#228

I cannot work on it at the moment (and will be away for the next two weeks). If you send a PR against the v4-backports branch I can make the release ASAP even this week

Well it turns out that cohttp-lwt-unix 4.1.1 compiles fine with cmdliner 1.2.0: changing only the version constraint suffices. What should I do?

Also the tests and the examples?

I think the issue is that cohttp-lwt-unix until recently used to ship three binaries: https://github.com/mirage/ocaml-cohttp/tree/v4-backports/cohttp-lwt-unix/bin

These need to be ported to cmdliner >= 1.1 for the package to work. It should be a relatively small patch, like 4cd36b5

I will see if I find 5 minutes to do it

A release with the compatibility is submitted to the opam-repo. I am going to close the issue

I would recommend ocsigen to update to 5, version 4 is no longer maintained

Thank you for your prompt reaction!

I would recommend ocsigen to update to 5, version 4 is no longer maintained

Agreed. I made a PR to ocsigenserver: ocsigen/ocsigenserver#229 and meanwhile, I added a custom patch in belenios: glondu/belenios@2efdfbf