miracle2k / webassets

Asset management for Python web development.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Passing an environment to ExternalTool.subprocess

gregersn opened this issue · comments

Is there a reason that the env-option is not set up to be passed on to Popen.subprocess?

I am quite new to using this library, and I like it very much. But I have now run across an issue where I need to set some environment variables for an external tool, to get it to work. And my first thought was to just throw the env=foo to subprocess in the external tool filter. But discovered that that wasn't an option.

Adding it to the ExternalTool-class wouldn't be a problem, but I wanted to see if there was any thought behind why it is like it is, and if that would be advised against?