mir-dataset-loaders / mirdata

Python library for working with Music Information Retrieval datasets

Home Page:https://mirdata.readthedocs.io/en/stable/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adding the latest version of compmusic_otmm_makam

sertansenturk opened this issue · comments

Hello mirdata people!

As we discussed aeons ago, compmusic_otmm_makam has a fix version that was not available when @genisplaja was implementing the original loader.

It was added to Zenodo (link) later, and it would be nice to have the latest version available in mirdata. I believe it is a small task, and I am happy to make the change myself.

To the best of my understanding, all I need to do is to follow the guideline in contributing.html#datasets-with-multiple-versions:

As the acceptance criteria, I could:

  • Add/update the unittests
  • Run (ad-hoc?) integration tests ensuring either version is downloaded appropriately.

Please let me know your thoughts, if I need to show extra care on some bits & bobs, and please do not hesitate to point out any concerns.

P.S: pinging @nkundiushuti, @genisplaja, @rabitt for visibility

@genisplaja is this related to the current loader included in mirdata?

Yes! We actually got started with discussions with @sertansenturk on how to push this update forward but it is still pending... I can work on that issue when I'm back from the conferences in India. I think the fix is quite easy to apply, so I'll note it down in my TODO list :)