Giters

minio / simdjson-go

Golang port of simdjson: parsing gigabytes of JSON per second

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

make test: TestNDJSON fails with 'unsupported platform' on s390x architecture.

opened this issue · comments

commented

While building minio on s390x arch and then running the unit tests. The 'TestNDJSON/parking-citations-10' test at 'reader_test.go:74' fails with an 'Unsupported platform' message.
The test was introduced when the simdjson-go package was added into minio.

Expected Behavior

Test passes or warns gracefully.

Current Behavior

--- FAIL: TestNDJSON (0.00s)
    --- FAIL: TestNDJSON/parking-citations-10 (0.00s)
        reader_test.go:74: Unsupported platform
FAIL
FAIL	github.com/minio/minio/pkg/s3select/simdj	0.009s

Steps to Reproduce

  1. make
  2. make install
  3. make test

Context

I'm trying to install minio on Linux on Z (s390x architecture). When I run the unit tests, one fails.
The one that fails is the one introduced by pulling in the simdjson-go package.
This package is obviously only meant to run on an amd64 arch.
I'm wondering what kind of impact this new simdjson-go package has on minio.
I'm also wondering what the level of impact this test failing is having on minio.

Possible solutions

Make the failure a warning and/or make the simdjson-go package fallback to an implementation that is non-arch specific.

Your Environment

  • Version used (minio version): RELEASE.2020-03-09T18-26-53Z
  • Operating System and version (uname -a): Linux 4.15.0-52-generic minio/minio#56-Ubuntu SMP Tue Jun 4 22:52:27 UTC 2019 s390x s390x s390x GNU/Linux
commented

Disabled the simdjson tests for non-amd64 architectures.