Giters

minetest / minetest

Minetest is an open source voxel game-creation platform with easy modding and game creation

Home Page:https://www.minetest.net/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace core::list with std::list

paradust7 opened this issue · comments

commented

This is to track both pull requests.

Biggest changes were made to IGUIElement and CGUITreeViewNode. I noticed they were doing linear searches for almost every operation touching the list. So I added a field (ParentPos) for both of them, to make list operations constant-time.

commented

Here's my plan on merging these refactors:

  • (Test them)
  • Merge all three into IrrlichtMt
  • Merge all three into Minetest
  • Tag IrrlichtMt 1.9.0mt6
  • Update version used in CI to that so everything is green again