[Feature Request] Add support for GTK4 titlebar

Question

[Feature Request] Add support for GTK4 titlebar

julianfairfax opened this issue a year ago · comments

It seems Minetest is based on this engine. When installing Minetest on a Linux system, or at least, a GNOME system, it has a GTK3 titlebar. It would be nice if support could be added for a GTK4 titlebar, as that's the new standard on GNOME systems.

DS · Answer 1 · Fri Apr 07 2023 21:45:49 GMT+0800 (China Standard Time)

We are planning to switch to SDL2. Please try compiling with -DUSE_SDL2. If the issue persists, it's an upstream issue I think (SDL probably sets the window decorations).

DS · Answer 2 · Sat Apr 08 2023 00:12:50 GMT+0800 (China Standard Time)

Are you sure you have SDL2 installed? In arch linux at least, SDL2Config.cmake is provided by the package.

Julian · Answer 3 · Sat Apr 08 2023 00:14:31 GMT+0800 (China Standard Time)

We are planning to switch to SDL2. Please try compiling with -DUSE_SDL2. If the issue persists, it's an upstream issue I think (SDL probably sets the window decorations).

Compiling with SDL2 still leaves a GTK3 titlebar, or at least a non-libadwaita one

Vitaliy · Answer 4 · Sat Apr 08 2023 23:41:18 GMT+0800 (China Standard Time)

Window frame is rendered by the window manager, not by the app.

Oh wait, that’s GNOME. Still, the frame you see is likely rendered by the window manager; I doubt SDL links to GTK just to render the titlebar.

Julian · Answer 5 · Mon Apr 10 2023 02:43:11 GMT+0800 (China Standard Time)

So... where should I be opening an issue for this?

Vitaliy · Answer 6 · Mon Apr 10 2023 04:01:13 GMT+0800 (China Standard Time)

I doubt SDL links to GTK just to render the titlebar.

Correction: it may link to libdecor which may in fact load GTK for that.

So, try running Minetest with the SDL_VIDEO_WAYLAND_ALLOW_LIBDECOR environment variable set to 0 to disable libdecor. If that fixes the problem, report it to libdecor (in fact, if their README is up to date, they only support GTK3 currently). Otherwise, report it to GNOME shell.

Julian · Answer 7 · Mon Apr 10 2023 04:12:06 GMT+0800 (China Standard Time)

I doubt SDL links to GTK just to render the titlebar.

Correction: it may link to libdecor which may in fact load GTK for that.

So, try running Minetest with the SDL_VIDEO_WAYLAND_ALLOW_LIBDECOR environment variable set to 0 to disable libdecor. If that fixes the problem, report it to libdecor (in fact, if their README is up to date, they only support GTK3 currently). Otherwise, report it to GNOME shell.

It doesn't fix the problem, neither with SDL2 nor without. It probably is in fact a libdecor limitation then.

Vitaliy · Answer 8 · Mon Apr 10 2023 04:28:27 GMT+0800 (China Standard Time)

It probably is in fact a libdecor limitation then.

While libdecor likely has that limitation your testing suggests that GNOME shell also has that limitation, i.e. for whatever reason, it only provides GTK3 titlebars for non-GTK windows.