qsocks + node -> cannot redefine property: hasOwnPropertyCI

Question

qsocks + node -> cannot redefine property: hasOwnPropertyCI

skokenes opened this issue 8 years ago · comments

Trying to run the qsocks node simple example with qsocks 3.0.5, getting the following error:

/Users/skokenes/Documents/Client/Axis Group/sensible/node_modules/qsocks/qsocks.js:25
Object.defineProperty(Object.prototype, "hasOwnPropertyCI", {
^

TypeError: Cannot redefine property: hasOwnPropertyCI

Any idea why I would get this error? This is running qsocks in Node, no other libraries or polyfills, etc being loaded

Alexander Thor · Answer 1 · Tue Sep 20 2016 01:20:50 GMT+0800 (China Standard Time)

Just tried running on Node 6.0.0. Which version of node are you running?

Speros Kokenes · Answer 2 · Tue Sep 20 2016 02:39:36 GMT+0800 (China Standard Time)

Node v4.2.4

Speros Kokenes · Answer 3 · Tue Sep 20 2016 03:36:18 GMT+0800 (China Standard Time)

my bad, i was loading in another library that is messing this up. I will investigate further...

Would it make sense to check if Object has the hasOwnPropertyCI property before defining it?

Speros Kokenes · Answer 4 · Tue Sep 20 2016 03:42:57 GMT+0800 (China Standard Time)

ok now I feel really dumb - the reason I am getting this error is because I loaded my library first (which already bundled in qsocks), then loaded qsocks again. So it is running qsocks twice, thus trying to patch that property twice.

Still, does it make sense to check that it hasnt been added already before defining the property?