mimblewimble / secp256k1-zkp

Fork of secp256k1-zkp for the Grin/MimbleWimble project

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

generator problems

antiochp opened this issue · comments

The following is called in the various range proof functions -

secp256k1_generator_load(&genp, gen);

We're not passing in gen from Grin (via rust-secp256k1-zkp) and it is not clear to me what we need to be doing here.

Actually looks like the code relies on gen as input param in these functions -

  • secp256k1_pedersen_commit
  • secp256k1_rangeproof_verify
  • secp256k1_rangeproof_rewind
  • secp256k1_rangeproof_sign

And from the comments in include/secp256k1_rangeproof.h -

 gen:        additional generator 'h'

This (I believe) is fixed - we pass in a gen via grin code now.