milux / ctldap

LDAP Wrapper for ChurchTools

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SSL doesn't seem to work

teleharry opened this issue · comments

The options seems to be missing in const server = ldap.createServer();
So, ldaps doesn't work, even ldapCertFilename and ldapKeyFilename ist defined.

Could you change it for future release?

if (config.ldapCertFilename && config.ldapKeyFilename) {
  const ldapCert = fs.readFileSync(new URL(`./${config.ldapCertFilename}`, import.meta.url), { encoding: "utf8" }),
      ldapKey = fs.readFileSync(new URL(`./${config.ldapKeyFilename}`, import.meta.url), { encoding: "utf8" });
  options = { certificate: ldapCert, key: ldapKey };
}
const server = ldap.createServer(options);
commented

If you already have fixed that, could you provide us a PR please? :)

commented

Fixed in version 3.1.0.