mikepenz / AboutLibraries

AboutLibraries automatically collects all dependencies and licenses of any gradle project (Kotlin MultiPlatform), and provides easy to integrate UI components for Android and Compose-jb environments

Home Page:http://mikepenz.github.io/AboutLibraries/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

GPL license

mbiebl opened this issue · comments

Version: 10.7.0

Related to #892, I also wanted to add a custom library (which is included as git submodule), that uses GPL-3-0-or-later.
What I did is basically the same as in
mbiebl@964ba88

Yet, the license information is not shown as can be seen in the AboutLibraries demo app.

Argh, sorry for mixing this up (3.0 vs 3-0). Not sure how this happened. Thanks for having a closer look.

I can confirm now, that this work in the main Activity.
In the "Compose Activity" though, tapping on the license info does not open a browser with a link to spdx.org.
Can you confirm this behaviour?

Yes that is correct. In the Compose default behaviour it would show a dialog instead of launching a web viewer.

However for this license the plugin fails to fetch the respective text format license. Normally the SPDX website exposed a *.txt file per html page: https://spdx.org/licenses/GPL-3.0-or-later.html -> https://spdx.org/licenses/GPL-3.0-or-later.txt however that one is not accessible for this license.

So this information is not available.

You can connect a onLibraryClick and launch the web viewer on the url though.

val uriHandler = LocalUriHandler.current
uriHandler.openUri(uri)

Is it possible to change the default behaviour of the Compose UI module to behave like the old/legacy UI module?

If not, there is probably nothing left to do in this ticket and it can be closed.

You mean it launching the browser with the license?

You can, pass in the onLibraryClick function and make it launch the url.