Wanted to see if you would be open to allowing flexibility on the route where metrics where exposed?
fruiz1 opened this issue · comments
Looks like per server.js (/metrics) is the preferred endpoint where the data gets exposed. Would you be open to a pull request that would allow this to be changed? examples could be /stats, /health, etc. Basically whatever is passed in as a parameter. Thank you!
I don't want to require a version bump, so we need to handle this function
signature, but yes.
Let's make the first argument to
https://github.com/mikejihbe/metrics/blob/master/reporting/server.js#L9
accept either a numerical port or an options object with port and path in
it, then add some documentation.
On Wed, May 25, 2016 at 2:08 PM, Frank Ruiz notifications@github.com
wrote:
Looks like per server.js (/metrics) is the preferred endpoint where the
data gets exposed. Would you be open to a pull request that would allow
this to be changed? examples could be /stats, /health, etc. Basically
whatever is passed in as a parameter. Thank you!—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#34
Mike Ihbe
MustWin - Principal
mike@mustwin.com
mikejihbe@gmail.com
skype: mikeihbe
Cell: 651.283.0815
Awesome. I forked the repo, and will start making the necessary modifications. I'll send over a pull request shortly... thank you!