mikejihbe / metrics

A metrics library for Node.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

metrics run forever in the background

nicks opened this issue · comments

new metrics.Timer()

sets up a setInteval that basically runs forever, with no simple public API to turn it off. Currently the metrics tests hack around this with a global process event _metrics:stop_all.

Would you accept a PR that adds appropriate stop() methods to all appropriate classes, or some other API to fix this?

This definitely makes sense, so yes.

On Thu, Jan 16, 2014 at 10:01 AM, Nick Santos notifications@github.comwrote:

new metrics.Timer()

sets up a setInteval that basically runs forever, with no simple public
API to turn it off. Currently the metrics tests hack around this with a
global process event _metrics:stop_all.

Would you accept a PR that adds appropriate stop() methods to all
appropriate classes, or some other API to fix this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.

Mike Ihbe
MustWin - Principal

mike@mustw.in
mikejihbe@gmail.com
skype: mikeihbe
Cell: 651.283.0815