4.0.15.0 installer path is wrong

Question

4.0.15.0 installer path is wrong

unruledboy opened this issue 7 years ago · comments

Wilson Chen commented 7 years ago

https://github.com/mikefourie/MSBuildExtensionPack/releases/tag/4.0.15.0

the installer path is

C:\Program Files\MSBuildExtensionPack\4.0\ (missing slash between MSBuild and ExntensionPack)

rather than

C:\Program Files\MSBuild\ExtensionPack\4.0\

and causes trouble, like keep telling can't find "vsjlib.dll", and misleading to Visual J# installation problems -> wrong way.

Mike Fourie · Answer 1 · Sun Nov 05 2017 05:15:53 GMT+0800 (China Standard Time)

Hi, that path is intentional. What issue are you seeing?

Martin Gill · Answer 2 · Wed Jan 17 2018 21:09:47 GMT+0800 (China Standard Time)

<Import Project="$(MSBuildExtensionsPath)\ExtensionPack\4.0\MSBuild.ExtensionPack.tasks"/>

No longer works. As $(MSBuildExtensionsPath) is C:\Program Files (x86)\MSBuild\ set here: https://github.com/Microsoft/msbuild/blob/30b19e9f2cefb6d9675d660c8bb8b317c06ff9a1/src/MSBuild/app.amd64.config#L119

Rob McCready · Answer 3 · Fri Mar 23 2018 23:38:56 GMT+0800 (China Standard Time)

Yes, the issue is that changing the install path broke all existing Import statements.

Rob McCready · Answer 4 · Sat Mar 24 2018 01:15:07 GMT+0800 (China Standard Time)

FYI, you can adjust the import statements in your build files to look like this to compensate:

<Import Condition="Exists('$(MSBuildExtensionsPath)\ExtensionPack\4.0\MSBuild.ExtensionPack.tasks')" Project="$(MSBuildExtensionsPath)\ExtensionPack\4.0\MSBuild.ExtensionPack.tasks" />
<Import Condition="Exists('$(MSBuildExtensionsPath)\..\MSBuildExtensionPack\4.0\MSBuild.ExtensionPack.tasks')" Project="$(MSBuildExtensionsPath)\..\MSBuildExtensionPack\4.0\MSBuild.ExtensionPack.tasks" />

This will allow them to work with either version installed.