XML logger produces invalid XML sometimes

Question

XML logger produces invalid XML sometimes

alexeibs opened this issue 9 years ago · comments

Our VS project has a custom build step which is running Grunt to build some JS code. Grunt output includes some coloring escape sequences and these characters break XML generated by XML logger. For example, xsltproc from libxslt package fails wtih this error: "parser error : PCDATA invalid Char value 27".
As a workaround it is possible to pass --no-color argument to Grunt but I think XML logger should properly escape characters from MSBuild output.

Mike Fourie · Answer 1 · Mon Aug 31 2015 05:04:28 GMT+0800 (China Standard Time)

can you attach a log / repo?

Alexei Bykov · Answer 2 · Mon Aug 31 2015 18:47:26 GMT+0800 (China Standard Time)

I've created a test repository https://github.com/alexeibs/xml_logger_test
It needs Node.js and npm in PATH. I build it using this command:

msbuild LoggerTest.sln /t:Build /p:Configuration=Debug;Platform=win32 /logger:XmlFileLogger,MSBuild.ExtensionPack.Loggers.dll;logfile=msbuild_log.xml;encoding=UTF-8

Generated msbuild_log.xml should contain some illegal characters.

Alexei Bykov · Answer 3 · Mon Aug 31 2015 18:53:03 GMT+0800 (China Standard Time)

This is an example of generated XML
https://github.com/alexeibs/xml_logger_test/blob/master/msbuild_log.xml

Mike Fourie · Answer 4 · Wed Oct 28 2015 04:19:42 GMT+0800 (China Standard Time)

Thanks for the details. will look into a fix.

Mike Fourie · Answer 5 · Mon Jul 24 2017 06:07:09 GMT+0800 (China Standard Time)

Happy to take a PR for this.