Advertise stops early
mikedilger opened this issue · comments
Mine stopped at 370 left to go.
Also we should block out the advertise button if a current advertise is ongoing.
Looks like any error will stop the batch job. It is now stuck in a loop retrying that broken relay every 120 secs and no more advertise logs.
2024-06-13T12:04:46.574627Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://greensoul.space/
2024-06-13T12:04:46.919548Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://hist.nostr.land/
2024-06-13T12:04:46.987711Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://galaxy13.nostr1.com/
2024-06-13T12:04:47.163361Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://frens.nostr1.com/
2024-06-13T12:04:47.219026Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://hodlbod.nostr1.com/ completed with error: Websocket: WebSocket protocol error: HTTP version must be 1.1 or higher
2024-06-13T12:04:47.354612Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://hodlbod.nostr1.com/ will restart in 120 seconds to continue persistent jobs
2024-06-13T12:04:47.400114Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://gleasonator.dev/relay
2024-06-13T12:04:47.555950Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://inbox.nostr.wine/
2024-06-13T12:04:47.704392Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://lightningrelay.com/
2024-06-13T12:04:47.749374Z INFO gossip-lib/src/overlord/minion/mod.rs:523: Advertised relay lists to wss://freerelay.xyz/
2024-06-13T12:04:58.997212Z WARN gossip-lib/src/overlord/minion/mod.rs:225: wss://proxy-experiment.onrender.com/: Service Unavailable
2024-06-13T12:04:59.965861Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://proxy-experiment.onrender.com/ completed with error: Websocket: HTTP error: 503 Service Unavailable
2024-06-13T12:05:00.121139Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://proxy-experiment.onrender.com/ will restart in 120 seconds to continue persistent jobs
2024-06-13T12:06:48.174558Z WARN gossip-lib/src/overlord/minion/mod.rs:238: wss://hodlbod.nostr1.com/: Unable to parse response as NIP-11 (expected value at line 1 column 1): <html><body><h1>403 Forbidden</h1>
Request forbidden by administrative rules.
</body></html>
2024-06-13T12:06:48.841273Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://hodlbod.nostr1.com/ completed with error: Websocket: WebSocket protocol error: HTTP version must be 1.1 or higher
2024-06-13T12:06:49.009783Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://hodlbod.nostr1.com/ will restart in 120 seconds to continue persistent jobs
2024-06-13T12:07:00.784554Z WARN gossip-lib/src/overlord/minion/mod.rs:225: wss://proxy-experiment.onrender.com/: Service Unavailable
2024-06-13T12:07:01.960092Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://proxy-experiment.onrender.com/ completed with error: Websocket: HTTP error: 503 Service Unavailable
2024-06-13T12:07:02.121295Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://proxy-experiment.onrender.com/ will restart in 120 seconds to continue persistent jobs
2024-06-13T12:08:49.798272Z WARN gossip-lib/src/overlord/minion/mod.rs:238: wss://hodlbod.nostr1.com/: Unable to parse response as NIP-11 (expected value at line 1 column 1): <html><body><h1>403 Forbidden</h1>
Request forbidden by administrative rules.
</body></html>
2024-06-13T12:08:50.592435Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://hodlbod.nostr1.com/ completed with error: Websocket: WebSocket protocol error: HTTP version must be 1.1 or higher
2024-06-13T12:08:50.772116Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://hodlbod.nostr1.com/ will restart in 120 seconds to continue persistent jobs
2024-06-13T12:08:59.821209Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://relay.snort.social/ completed with error: Websocket: WebSocket protocol error: Connection reset without closing handshake
2024-06-13T12:09:00.002484Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://relay.snort.social/ will restart in 60 seconds to continue persistent jobs
2024-06-13T12:09:02.941910Z WARN gossip-lib/src/overlord/minion/mod.rs:225: wss://proxy-experiment.onrender.com/: Service Unavailable
2024-06-13T12:09:03.952967Z ERROR gossip-lib/src/overlord/mod.rs:465: Minion wss://proxy-experiment.onrender.com/ completed with error: Websocket: HTTP error: 503 Service Unavailable
2024-06-13T12:09:04.116111Z INFO gossip-lib/src/overlord/mod.rs:549: Minion wss://proxy-experiment.onrender.com/ will restart in 120 seconds to continue persistent jobs
I put in code to not restart a minion if all of it's jobs are advertise jobs, so it won't loop like that.
I added tighter bounds on which relays to use.
I disabled the advertise button while advertise is happening.
Still, when I get to hodlbod.coracle.tools it never removes the job from GLOBALS.active_advertise_jobs and advertise never completes. So there must be some means that a minion can die without this removal happening, though I haven't figured out what it is yet.
I reworked this code to be much more straightforward:
- 4 per second, don't care if they fail or not
- It orders the relays first and does the highest rank/success relays first
- Updates the "Advertise" button which is disabled to indicate how many to go before it is done.