mikeal / merge-release

Automatically release all merges to master on npm.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Version tags are not pushed

tobyjsullivan opened this issue · comments

The docs mention that tags should be pushed to the repo automatically.

* Push a tag for the new version to GitHub.

We're currently not seeing any tags pushed to our private repo when the action runs. I don't see anything in the docs about special configuration for pushing repo tags. Am I missing some sort of configuration to get tags working?

I'm looking at the code, and it looks like this part is simply commented out. Is that right?

/*
const env = process.env
const remote = `https://${env.GITHUB_ACTOR}:${env.GITHUB_TOKEN}@github.com/${env.GITHUB_REPOSITORY}.git`
exec(`git push ${remote} --tags`)
*/

Wow, looks like that was disabled as part of a debugging operation a longtime ago: 0cdb164

Of course the work-around is simple, just push the tags:

      - name: Publish
        uses: mikeal/merge-release@master
        # ... etc...

      - name: Push generated git tags
        run: |
          git push --tags