Support for marked@0.6.0

Question

Support for marked@0.6.0

mitschmidt opened this issue 5 years ago · comments

Thanks for this great package.

Unfortunately after updating marked to 0.6.0, npm install complains about the version:
npm[app] WARN marked-terminal@3.1.1 requires a peer of marked@^0.4.0 || ^0.5.0 but none is installed. You must install peer dependencies yourself.

Is this an actual compatibility issue or is it sufficient to fix the supported version number in the package.json?

Mikael Brevik commented 5 years ago

Out now

Mikael Brevik · Answer 1 · Mon Jan 07 2019 00:23:51 GMT+0800 (China Standard Time)

Hi! I haven't checked out the changes for 0.6.0, but given that there are no breaking plugin changes (which it can be with a minor release change sub 1.0.0), it should be fine. I saw this PR which could indicate it works fine: #48

Mikael Brevik · Answer 2 · Mon Jan 07 2019 00:24:39 GMT+0800 (China Standard Time)

If you could test the PR out and it works I would appreciate it and I will happily merge and update. Seems as the tests works at least

Mikael Brevik · Answer 3 · Wed Jan 09 2019 21:32:03 GMT+0800 (China Standard Time)

You can test the master branch now (npm i mikaelbr/marked-terminal)