mihaiblaga89 / movie-trailers

Description

1. Mobile friendly
2. Search functionality
3. 10 unit tests using Jest
4. Used SweetAlert for messages
5. Prettier + Eslint + Husky precommit hook
6. Tested on Chrome, Firefox and Safari

Remarks

1. Decided to not show the movie/show title on top of the image because that would clutter the UI and it's a bit reduntant anyway because all the posters have the title written on them.

Instructions

1. git clone <repo>
2. cd dir
3. yarn
4. npm start

The app should open a new browser in the default browser. If it doesn't, open http://localhost:3000 manually.

Running the tests

npm t || yarn test

Pressing a will run all the tests. Pressing w will show the help.

Known issues

1. On some versions yarn complains about "react-scripts > pnp-webpack-plugin > ts-pnp@1.0.1" has unmet peer dependency "typescript@*". This is a known issue in create-react-app (Link1, Link2) That's the reason for adding the yarn requirement in package.json.
2. The server serving the video is not CORS-friendly. The browser tries to do the preflight requests with the OPTIONS method but it's not implemented server-side. The video still plays but the console turns red.

To be improved

1. Pagination for carousels. Only the first 20 are displayed now, the API support is added but there was no way to easily add the pagination with the carousel module.
2. Family and documentaries display only movies. Add another 2 carousels for series as well or do 2 calls and merge the results in one.