Middleman 4.3.11 w/ Ruby 2.7+ uses obsolete `URI.escape`

Question

Middleman 4.3.11 w/ Ruby 2.7+ uses obsolete `URI.escape`

infews opened this issue 3 years ago · comments

Davis W. Frank commented 3 years ago

Expected behavior and actual behavior

When building an HTML file that has external URLs...

Expected

No warnings

Actual

See the warnings:

/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/extensions/asset_hash.rb:90: warning: URI.escape is obsolete
/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/builder.rb:232: warning: URI.escape is obsolete
      create  build/stylesheets/all-4ad24781.css
...
/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/builder.rb:232: warning: URI.escape is obsolete
/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/builder.rb:232: warning: URI.escape is obsolete
/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/builder.rb:232: warning: URI.escape is obsolete
      create  build/images/dwf-d2380e10.png

/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/builder.rb:232: warning: URI.escape is obsolete
/Users/dwfrank/workspace/blog/vendor/bundle/ruby/2.7.0/gems/middleman-core-4.3.11/lib/middleman-core/builder.rb:232: warning: URI.escape is obsolete
      create  build/tags/job-search/index.html

Steps to reproduce the problem (from a clean middleman installation)

bundle exec middleman build clean

Additional information

Ruby version: 2.7.0
Middleman version: 4.3.11
OS version: MacOS 11.3

Potential Fix

https://stackoverflow.com/questions/65423458/ruby-2-7-says-uri-escape-is-obsolete-what-replaces-it

Thomas Reynolds · Answer 1 · Sun May 23 2021 04:22:12 GMT+0800 (China Standard Time)

Can you post more information, I'm not understanding this bug report.

Davis W. Frank · Answer 2 · Sun May 23 2021 06:54:46 GMT+0800 (China Standard Time)

Whoops! I'm so sorry. Copy/Paste error. I've updated the title & content.

Takuya N · Answer 3 · Tue Jun 15 2021 15:16:58 GMT+0800 (China Standard Time)

@infews Why don't you use gem 'middleman', git: 'https://github.com/middleman/middleman.git', ref: 'd180ca3' in your Gemfileinstead of gem 'middleman', '4.3.11'?

Thomas Reynolds · Answer 4 · Thu Jun 17 2021 06:01:45 GMT+0800 (China Standard Time)

v4.4.0 released

Davis W. Frank · Answer 5 · Thu Jun 17 2021 07:54:48 GMT+0800 (China Standard Time)

Excellent! Thanks!

On Wed, Jun 16, 2021 at 3:01 PM Thomas Reynolds ***@***.***> wrote: v4.4.0 released — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADA4GGS2OTW5NZLOSMIKDTTENNHANCNFSM45K2FYDQ> .

-- --dwf

Takuya N · Answer 6 · Mon Jul 19 2021 00:03:07 GMT+0800 (China Standard Time)

@infews @tdreyno Could you close this issue?

Kolja · Answer 7 · Sat Feb 05 2022 11:34:41 GMT+0800 (China Standard Time)

I guess this means, that 2.7 is at least needed to run middleman?

Thomas Reynolds · Answer 8 · Wed Feb 09 2022 10:54:03 GMT+0800 (China Standard Time)

It's just a warning message. 4.x still supports 2.5+