microsoft / vscode-loader

An universal Asynchronous Module Definition (AMD) Loader developed primarily to load VSCode's sources.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

String format should check number of args against placeholders to detect mismatches

dbaeumer opened this issue · comments

The place to check is here:

function _format(message: string, args: (string | number | boolean | undefined | null)[], env: Environment): string {

@dbaeumer Do you want to look into doing this? I think you wrote the initial _format implementation.

We are discussing whether @TylerLeonhardt takes over more so I asked him to look into it. Will assign to him for now.

I take a look at this next milestone probably.