Giters

microsoft / onnxjs

ONNX.js: run ONNX models using JavaScript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TopK-1 CPU unittests

J3698 opened this issue · comments

commented

I am almost done implementing CPU TopK-1 and am passing the op tests I wrote. However it takes quite a while to write the unit tests, and I feel even if I spent another hour writing tests, I could be missing something.

So I'm thinking I should also write some additional randomized test cases in the folder unittest/cpu (which does not exist). I think this would be more exhaustive and take less time to write more tests. If this sounds okay I will start on it in a few days.

If it is also okay, I'd like to add an option to run one unit test at a time. I would change npm test unittest to npm test unittests, and add an npm test unittest [test], which only runs one unit test. If that is okay, I will also get started on that in the next couple of days.

Thanks!

commented

Thanks for your contribution! Sorry for the late reply.

we are currently doing a different approach to support CPU kernels in browser. We compiles ONNX Runtime as a whole so that we can have a full CPU kernel coverage. ONNX Runtime Web offers enhanced user experience and improved performance. Please visit ONNX Runtime Web to get more details.