[Bug]: Suspensions do not work when `canSendPositionUpdates` is false for `LiveMediaSessionCoordinator`
ryanbliss opened this issue · comments
Describe the bug
When activating a suspension in LiveMediaSessionCoordinator
while canSendPositionUpdates
is set to false, the createPositionUpdateEvent
function in GroupCoordinatorState
cannot update the local user's state to suspended. Thus, it will snap them to the group state still.
To Reproduce
- Set one client to
canSendPositionUpdates
to true and another to false - Activate suspension on the client with
canSendPositionUpdates
== false - It will not work
Not sure if createPositionUpdateEvent
is actually source of problem, but I did confirm that wasn't happening when it normally would, so I suspect it is related.
This branch of this sample repo makes it easy to test: https://github.com/ryanbliss/live-share-react-media-template/tree/ryanbliss/large-meeting-optimized. To force canSendPositionUpdates
to false, set ?isShareInitiator=false
in the URL before the #{containerId}
, and ensure that client is not in control.
Expected behavior
- Users who can't send position updates should still be able to locally suspend.
- Not sure about wait points...